-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Title: avoid accidental types requests #60531
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +25 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
@youknowriad Damn I'm sorry but I just realised I forgot it too, so I guess I don't have the muscle memory quite yet :( |
What?
In #49839, an effort was made to avoid OPTIONS requests, however the hack introduced there is causing incorrect calls to
getEntityConfig
(with thepostType
being set tofalse
) and causes many requests to the/wp/v2/types?context=view
endpoint because it cannot find the config.Let's adjust the
useSelect
call to correctly return early and avoid calling thecanUserEditEntityRecord
altogether.Why?
How?
Return early inside the
useSelect
call.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast