Font Library: Fix modal scrollbar #60641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mikachan
commented
Apr 10, 2024
| @@ -181,7 +181,6 @@ function InstalledFonts() { | |||
| ) ) } | |||
| </> | |||
| ) } | |||
| <Spacer margin={ 16 } /> | |||
There was a problem hiding this comment.
I think this was added to create some space between the content and the footer. I don't think this is needed now that it's possible to see the bottom of the content above the footer.
mikachan
requested review from
pbking,
matiasbenedetto,
creativecoder and
t-hamano
|
Size Change: +14 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
packages/edit-site/src/components/global-styles/font-library-modal/style.scss
Outdated
Show resolved
Hide resolved
creativecoder
approved these changes
Apr 11, 2024
t-hamano
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
I'm not sure why you're seeing 68.8px there, although I know that's what the height was before I set it to 70px. Could this maybe be caused by a caching issue on the CSS?
Sorry, I was debugging with trunk 😅 This PR does indeed have a footer height of 70px and is working as expected.
matiasbenedetto
added
the
Backport to WP Minor Release
|
I added the "Backport to WP Minor Release" tag to include it in WordPress 6.5.3. |
3 tasks
|
Thanks @matiasbenedetto! I've added this to the 6.5.x board for consideration in the 6.5.3 release. |
|
Confirming that this will be included in the 6.5.3 release. |
creativecoder
pushed a commit
that referenced
this pull request
May 1, 2024
* Make footer a fixed height; add margin to modal content * Remove Spacer from bottom of Library tab content * Add variable for footer height size Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: creativecoder <grantmkin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
|
I just cherry-picked this PR to the update/fixes-for-wp-6-5-3 branch to get it included in the next release: 25c18ac |
creativecoder
removed
the
Backport to WP Minor Release
aaronjorbin
pushed a commit
that referenced
this pull request
May 2, 2024
* Make footer a fixed height; add margin to modal content * Remove Spacer from bottom of Library tab content * Add variable for footer height size Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: creativecoder <grantmkin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improves the display of the Font Library modal's scrollbar to prevent it from disappearing behind the footer.
Why?
Fixes #54401.
How?
This adjusts the CSS of the Font Library modal's content to add a bottom margin, which means it can take into account the height of the footer when displaying the scrollbar. I've also made the footer a fixed height so that these two measurements always match.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-04-10.at.20.19.41.mov