Fix layout of Data Views filter chip #60669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Apr 11, 2024
| @@ -706,8 +706,8 @@ | |||
| border-radius: $grid-unit-20; | |||
| border: 1px solid transparent; | |||
| cursor: pointer; | |||
| padding: 0 $grid-unit-15; | |||
| height: $grid-unit-40; | |||
| padding: $grid-unit-10 $grid-unit-15; | |||
There was a problem hiding this comment.
I'd love @jameskoster thoughts about the top padding, since it also affects the chip when it's in a single line.
|
Thank you for the PR, it would certainly be good to address this, but I'm not sure adding padding is the way to go. Mostly because it doesn't stop the text from wrapping, which I consider to be the biggest offender here – it makes the chip difficult to interpret at a glance. Ideally the full text would appear on a single line like so: 
If there's a reliable way to do that then it could be worth merging as a short-term solution. But it's going to get a bit tricky down the road if the filter is multi-select and has many values, e.g. We probably need a more polished solution that solves these problems across all layouts. How should we handle extremely long chips like the examples above... should values truncate? Should multi-selections be simplified to e.g. |
|
I'd echo Jay's instincts here, we should find ways to avoid the chip wrapping. Whether smaller font sizes, eliding text, etc. A bit of an out there solution that the Google app store employs is to marquee/scroll the text. |
|
No problem and thanks for the good instincts. No wrapping approach sounds like a good goal. One thing I've encountered with a similar situation I encountered during work on the Link UI - when you try and avoid wrapping and text strings get particularly long the instinct is to truncate the text. That's necessary to avoid overflowing. However there needs to be a means (perceivable to all) for users to access the full text. I'll close this one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes layout of data views filter chip to account for variable lengths of filter text.
Why?
Currently a fixed height is applied to the chip which means that for filters which have a lot of text the UI looks broken as the text butts up against the edge of the chip. Instead there should be a nice spacing between the text and the edge of the chip.
How?
Avoids relying on fixed height and instead requires a min height and uses veritcal padding to ensure spacing around text is maintained at all times.
Testing Instructions
Listlayout.trunkand text does not butt up against edge of the chip.TemplatesListlayout.Testing Instructions for Keyboard
Screenshots or screencast
Trunk
This PR