-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - Crash fixes when pasting HTML content #60676
Conversation
Size Change: -18 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
# Conflicts: # packages/react-native-editor/CHANGELOG.md
Flaky tests detected in 39cf61f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8754892767
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests succeeded for me @geriux! 🚀
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Related PRs:
What?
Addresses some of the issues in #55652
Why?
To prevent the editor from crashing in some cases where users paste content from other text editors like Microsoft Word.
How?
By addressing two of the issues listed in #55652
special-comment-converter
For this case it adds the
dataset
polyfill as we did for other cases, it has the basic functionality to set/getdata
attributes.It also enables the tests for this filter.
image-corrector
For this filter, it updates the native variant bringing some parts of the web's code to clear the
src
value if the image tag has afile
value.Testing Instructions
Note
Please use the following builds to test:
special-comment-converter
HTML
image-corrector
HTML
Testing Instructions for Keyboard
N/A
Screenshots or screencast
special-comment-converter
SpecialCommentBefore.mov
SpecialCommentAfter.mov
image-corrector
ImageCorrectorBefore.mov
ImageCorrectorAfter.mov