Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Typescript to 5.4.5 #60793

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Update Typescript to 5.4.5 #60793

merged 3 commits into from
Apr 19, 2024

Conversation

simonhammes
Copy link
Contributor

What?

Update Typescript to 5.4.5

Testing Instructions

  • CI
  • npm run build locally

@simonhammes simonhammes marked this pull request as ready for review April 17, 2024 19:42
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: simonhammes <simonhammes@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

jsnajdr
jsnajdr approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good 👍 I just tried to upgrade TS locally and arrived at exactly the same changes.

@jsnajdr jsnajdr added the [Type] Build Tooling Issues or PRs related to build tooling label Apr 19, 2024
@WordPress WordPress deleted a comment from github-actions bot Apr 19, 2024
jsnajdr
jsnajdr reviewed Apr 19, 2024
View reviewed changes
packages/e2e-test-utils-playwright/tsconfig.json
@@ -4,7 +4,7 @@
"compilerOptions": {
"incremental": false,
"composite": false,
"module": "CommonJS",
"module": "Node16",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done to fix an error:

error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.

I'm not really sure what exactly this does. The matching moduleResolution: node16 field was added by @swissspidy in https://github.com/WordPress/gutenberg/pull/52993/files#r1288451752

@jsnajdr jsnajdr merged commit e33cb88 into WordPress:trunk Apr 19, 2024
64 of 67 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 19, 2024
@jsnajdr jsnajdr mentioned this pull request Apr 19, 2024
Merged
@mirka mirka mentioned this pull request Apr 19, 2024
Merged
@simonhammes simonhammes deleted the typescript-5.4.5 branch April 19, 2024 18:01
@mirka mirka mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnajdr jsnajdr jsnajdr approved these changes

@kevin940726 kevin940726 Awaiting requested review from kevin940726 kevin940726 is a code owner

Assignees
No one assigned
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
Gutenberg 18.2
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhammes @jsnajdr