-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlignmentMatrixControl: Promote to stable #60913
AlignmentMatrixControl: Promote to stable #60913
Conversation
e5caade
to
ac94762
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
AlignmentMatrixControl
AlignmentMatrixControl
ac94762
to
567b352
Compare
AlignmentMatrixControl
'alignmentmatrixcontrol', | ||
'customselectcontrol-v2', | ||
'theme', | ||
'navigation', | ||
'progressbar', | ||
'theme', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorted alphabetically
Size Change: +26 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks, @fullofcaffeine, for the initial work and for getting it to the finish line @mirka! 🚀
packages/components/CHANGELOG.md
Outdated
@@ -357,6 +358,7 @@ | |||
### Deprecations | |||
|
|||
- `Navigation`: Soft deprecate component ([#59182](https://github.com/WordPress/gutenberg/pull/59182)). | |||
- `AlignmentMatrixControl`: Remove "experimental" designation ([#60913](https://github.com/WordPress/gutenberg/pull/60913)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we're adding this to the wrong release. Should this go up in its own new Deprecations section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 🙈
Icon: Object.assign( AlignmentMatrixControlIcon, { | ||
displayName: 'AlignmentMatrixControl.Icon', | ||
} ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -12,7 +12,11 @@ export { | |||
} from '@wordpress/primitives'; | |||
|
|||
// Components. | |||
export { default as __experimentalAlignmentMatrixControl } from './alignment-matrix-control'; | |||
export { | |||
/** @deprecated Import `AlignmentMatrixControl` instead. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan on adding a deprecation warning in a follow-up once all instances are migrated, or are we keeping it "soft deprecated" for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we can decide on a per-component basis, using reasoning from #61099. Maybe we'll want to do a more aggressive cleanup in the future, but I don't think it's a pressing need for the moment. I'm anticipating most of these to be passive deprecations.
Flaky tests detected in 6c062f6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10638099802
|
Seems like this got conflicted and will need a rebase. |
…on-for-alignmentmatrixcontrol
* Remove "experimental" designation for `AlignmentMatrixControl` * Add CHANGELOG entry * Tweak exports * Replace in app * Add changelog * Fix changelog --------- Co-authored-by: fullofcaffeine <fullofcaffeine@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Part of #59418
What?
Promote
AlignmentMatrixControl
to a non-experimental component.Why?
The strategy of prefixing exports with
__experimental
has become deprecated after the introduction of private APIs.Checklist
__experimental
prefix.__experimental
export for backwards compatibility.__experimental
in GB and components to the one without the prefix (including in Storybook stories).id
(get it from the storybook URL) to thePREVIOUSLY_EXPERIMENTAL_COMPONENTS
const array inmanager-head.html
so that old experimental story paths are redirected to the new one.✍️ Dev note
The
__experimentalAlignmentMatrixControl
component can now be imported asAlignmentMatrixControl
.The legacy
__experimentalAlignmentMatrixControl
is marked as deprecated.