-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontSizerPicker: Improve docs for default units #60996
Conversation
@@ -84,7 +84,6 @@ Default.args = { | |||
size: 26, | |||
}, | |||
], | |||
units: [ 'px', 'em', 'rem' ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing from the story args to make it clearer what the default is.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 🚀
What?
Clarify in the docs/code for FontSizerPicker that there is a default value for the
units
prop.Why?
I noticed when reviewing #60607 that this was unclear.
Testing Instructions
units
prop should still work, which is asserted by this unit test.