Grid interactivity: Make visualizer's cell UI at minimum 8x8 in size #61427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
noisysocks
removed
the
[Type] Bug
|
Size Change: +88 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
noisysocks
added
[Type] Bug
|
@tellthemachines: Do you think we should put this in 6.6? I'll fix the conflicts. |
|
I don't think it's needed for 6.6 because the problem we were trying to address with this was dragging into empty cells, which hasn't shipped yet. |
noisysocks
added
No Core Sync Required
|
#61025 includes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Small fix that I've split out of #59490.
Makes the grid visualiser show empty cells as being at minimum 8x8 in size.
Why?
This makes empty rows and columns in the grid appear at least 8px wide or tall. This allows the user to drag and drop into that cell (will be necessary in the future) and more easily resize grid items to span that cell.
How?
Splits each grid visualiser cell
<div />into a<div><div /></div>. The outer div is positioned by the grid layout and the inner div has a min size of 8x8.This also removes the
!importantkeywords from the grid visualiser CSS in favour of specificity hacks which, despite their name, are less hacky.Testing Instructions
Screenshots or screencast
Before:
After: