Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the site editor Admin Bar menu item #61851

Merged
merged 4 commits into from
May 24, 2024
Merged

Fix the site editor Admin Bar menu item #61851

merged 4 commits into from
May 24, 2024

Conversation

youknowriad
Copy link
Contributor

Follow-up to #61741

What?

Now that the details page has been removed entirely, we need to direct the admin bar menu item to the "edit" mode page directly.

Testing Instructions

1- Open the frontend of your website (block theme)
2- Click that the "site editor" link
3- The active template should be opened in the site editor in edit mode.

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 22, 2024
@youknowriad youknowriad requested a review from Mamaduka May 22, 2024 08:40
@youknowriad youknowriad self-assigned this May 22, 2024
@youknowriad youknowriad requested a review from spacedmonkey as a code owner May 22, 2024 08:40
@youknowriad youknowriad force-pushed the fix/admin-bar-menu-item branch from 0ec7d5d to 4800258 Compare May 22, 2024 08:41
@github-actions GitHub Actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.6/admin-bar.php
❔ lib/load.php

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added the Needs PHP backport Needs PHP backport to Core label May 22, 2024
Mamaduka
Mamaduka approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Riad!

Mamaduka
Mamaduka reviewed May 22, 2024
View reviewed changes
lib/compat/wordpress-6.6/admin-bar.php
)
);
}
remove_action( 'admin_bar_menu', 'wp_admin_bar_edit_site_menu', 40 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevents doing extra work in core.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Flaky tests detected in 35ff8de.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9190431345
📝 Reported issues:

@youknowriad youknowriad force-pushed the fix/admin-bar-menu-item branch from bc99088 to 3e84347 Compare May 22, 2024 11:23
ellatrix
ellatrix reviewed May 22, 2024
View reviewed changes
backport-changelog/6.6/61266.md Outdated
@@ -0,0 +1,3 @@
https://github.com/WordPress/wordpress-develop/pull/6605
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name needs to be 6605

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the content of backport-changelog/6.6/61266.md to include the core backport PR URL, or update the file name to match the core backport PR number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I though it was the Gutenberg PR number.

@Mamaduka
Copy link
Member

Can we merge this?

@youknowriad
Copy link
Contributor Author

Yeah forgot about it :P

@youknowriad youknowriad merged commit 859e257 into trunk May 24, 2024
63 checks passed
@youknowriad youknowriad deleted the fix/admin-bar-menu-item branch May 24, 2024 13:53
@github-actions github-actions bot added this to the Gutenberg 18.5 milestone May 24, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jun 4, 2024
@youknowriad @Mamaduka
@ellatrix @carstingaxion
Fix the site editor Admin Bar menu item (WordPress#61851)
23e65ec 
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
@ellatrix ellatrix mentioned this pull request Jun 5, 2024
Closed
@annezazu annezazu mentioned this pull request Jun 11, 2024
Closed
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@youknowriad @Mamaduka
@ellatrix @patil-vipul
Fix the site editor Admin Bar menu item (WordPress#61851)
c156fcd 
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix left review comments

@Mamaduka Mamaduka Mamaduka approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@youknowriad youknowriad

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs PHP backport Needs PHP backport to Core [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 18.5
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowriad @Mamaduka @ellatrix