Try having less of the tree within EditorProvider
#61874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 16182fc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9195287608
|
stokesman
changed the title
EditorProvider
This was referenced May 22, 2024
youknowriad
reviewed
May 22, 2024
| @@ -349,7 +342,16 @@ export default function Editor( { isLoading, onClick } ) { | |||
| /> | |||
| } | |||
| content={ | |||
| <> | |||
| <EditorProvider | |||
There was a problem hiding this comment.
So I didn't dive yet into the issue to understand it properly but for me, conceptually at least, EditorProvider should wrap the whole InterfaceSkeleton, it provides the context for the canvas, the header and the sidebar. The fact that the header and sidebar continue to work with this change is just because we're doing the useSubRegistry={ false } hack to allow third-party developers to access the core/editor store globally, without it, it would break both of these components as they won't be "talking" to the right store.
There was a problem hiding this comment.
Ok here's an alternative fix #61882
|
Closing in favor of #61882 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Trys a naive fix for some animations that are currently broken. It probably can generally make parts of the interface a teeny bit more snappy (less re-renders).
Why?
Fixes #60875 and fixes #61875.
How?
Moves
EditorProviderto wrap less of the interface—just the content.Testing Instructions