-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dummy content to function as an introduction to the editor. #623
Conversation
I really quite like this. It's very inspiring to see it come together cohesively like this. Really makes me excited to polish the embed block, the image blocks, the rest of the post content... the whole thing. Very very cool. There's one blocker, though. As a dane I consider it my solemn duty to defend the fact that LEGO is in allcaps. Always. Edit: Also, LEGO is the plural of LEGO. Examples:
This is important stuff. |
post-content.js
Outdated
'<!-- /wp:core/heading -->', | ||
|
||
'<!-- wp:core/text -->', | ||
'<p>I imagine prior to the launch of the iPod, or the iPhone, there were teams saying the same thing: the copy + paste guys are <em>so close</em> to being ready and we know Walt Mossberg is going to ding us for this so let\'s just not ship to the manufacturers in China for just a few more weeks… The Apple teams were probably embarrassed. But <strong>if you\'re not embarrassed when you ship your first version you waited too long</strong>.</p>', | ||
'<p>The goal of the new editor is to make adding rich content to WordPress simple and enjoyable. This whole post is composed of <em>pieces of content</em>—somewhat similar to Lego bricks—that you can move around and interact with. Move your cursor around and you\'ll notice the different blocks light up with outlines and arrows. Press the arrows to reposition blocks quickly, without fearing about losing things in the process of copying and pasting.</p>', | ||
'<p>What you are reading now is a <strong>text</strong> <strong>block</strong>, the most basic block of all. A text block can have multiple paragraphs, if that\'s how you prefer to write your posts. But you can also split it by hitting enter twice. Once blocks are split they get their own controls to be moved freely around the post...</p>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the individual words marked bold, instead of one tag encompassing both words?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just an artifact, will fix.
Can you use a longer blockquote, with some |
d544a39
to
ca26626
Compare
Added some images and text at the bottom. Should we find a different video, or move it upwards, out of the "lorem ipsum" text at the bottom? |
I moved the video and added a caption. I think we should merge this in and keep moving. |
Also snuck in a "code" so we can check the link boundary.
e41c43e
to
f04d10b
Compare
Merged, we'll keep refining this. |
The embed block's comment syntax should have been updated with consideration for #626. |
I missed it was broken after the rebase. |
Pretty sure that was my fault. Apologies, fixing. |
@jasmussen already submitted #675 |
This fixes a regression I introduced in #623 (comment).
Hah, sorry, deleting mine. |
No description provided.