Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dummy content to function as an introduction to the editor. #623

Merged
merged 4 commits into from
May 5, 2017

Conversation

mtias
Copy link
Member

@mtias mtias commented May 3, 2017

No description provided.

@mtias mtias added [Type] Developer Documentation Documentation for developers [Status] In Progress Tracking issues with work in progress labels May 3, 2017
@jasmussen
Copy link
Contributor

jasmussen commented May 3, 2017

I really quite like this. It's very inspiring to see it come together cohesively like this. Really makes me excited to polish the embed block, the image blocks, the rest of the post content... the whole thing. Very very cool.

There's one blocker, though. As a dane I consider it my solemn duty to defend the fact that LEGO is in allcaps. Always. allCapsDangit()! 😄

Edit: Also, LEGO is the plural of LEGO. Examples:

  • I played with LEGO
  • I lost all my LEGO
  • This LEGO brick is my favorite

This is important stuff.

post-content.js Outdated
'<!-- /wp:core/heading -->',

'<!-- wp:core/text -->',
'<p>I imagine prior to the launch of the iPod, or the iPhone, there were teams saying the same thing: the copy + paste guys are <em>so close</em> to being ready and we know Walt Mossberg is going to ding us for this so let\'s just not ship to the manufacturers in China for just a few more weeks… The Apple teams were probably embarrassed. But <strong>if you\'re not embarrassed when you ship your first version you waited too long</strong>.</p>',
'<p>The goal of the new editor is to make adding rich content to WordPress simple and enjoyable. This whole post is composed of <em>pieces of content</em>—somewhat similar to Lego bricks—that you can move around and interact with. Move your cursor around and you\'ll notice the different blocks light up with outlines and arrows. Press the arrows to reposition blocks quickly, without fearing about losing things in the process of copying and pasting.</p>',
'<p>What you are reading now is a <strong>text</strong> <strong>block</strong>, the most basic block of all. A text block can have multiple paragraphs, if that\'s how you prefer to write your posts. But you can also split it by hitting enter twice. Once blocks are split they get their own controls to be moved freely around the post...</p>',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the individual words marked bold, instead of one tag encompassing both words?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just an artifact, will fix.

@joyously
Copy link

joyously commented May 3, 2017

Can you use a longer blockquote, with some <em> or bold or text alignment? A lot of themes make quotes italic or big or bold and it's nice to have those in there to see what it looks like.
I like to use this for testing themes:
<blockquote cite="https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote"><p>The <strong>HTML <code>&lt;blockquote&gt;</code> Element</strong> (or <em>HTML Block Quotation Element</em>) indicates that the enclosed text is an extended quotation. Usually, this is rendered visually by indentation (see <a href="https://developer.mozilla.org/en-US/docs/HTML/Element/blockquote#Notes">Notes</a> for how to change it). A URL for the source of the quotation may be given using the <strong>cite</strong> attribute, while a text representation of the source can be given using the <a href="https://developer.mozilla.org/en-US/docs/Web/HTML/Element/cite" title="The HTML Citation Element &lt;cite&gt; represents a reference to a creative work. It must include the title of a work or a URL reference, which may be in an abbreviated form according to the conventions used for the addition of citation metadata."><code>&lt;cite&gt;</code></a> element.</p></blockquote> <cite>multiple contributors</cite> - MDN HTML element reference - blockquote

@mtias mtias force-pushed the update/dummy-content branch from d544a39 to ca26626 Compare May 4, 2017 12:03
@jasmussen
Copy link
Contributor

jasmussen commented May 5, 2017

Added some images and text at the bottom. Should we find a different video, or move it upwards, out of the "lorem ipsum" text at the bottom?

@jasmussen
Copy link
Contributor

I moved the video and added a caption. I think we should merge this in and keep moving.

@jasmussen jasmussen force-pushed the update/dummy-content branch from e41c43e to f04d10b Compare May 5, 2017 11:10
@jasmussen jasmussen removed the [Status] In Progress Tracking issues with work in progress label May 5, 2017
@jasmussen jasmussen requested a review from youknowriad May 5, 2017 11:23
@mtias mtias merged commit 2aaf988 into master May 5, 2017
@mtias mtias deleted the update/dummy-content branch May 5, 2017 12:27
@mtias
Copy link
Member Author

mtias commented May 5, 2017

Merged, we'll keep refining this.

@aduth
Copy link
Member

aduth commented May 5, 2017

The embed block's comment syntax should have been updated with consideration for #626.

@mtias
Copy link
Member Author

mtias commented May 5, 2017

I missed it was broken after the rebase.

@jasmussen
Copy link
Contributor

Pretty sure that was my fault. Apologies, fixing.

@mtias
Copy link
Member Author

mtias commented May 5, 2017

@jasmussen already submitted #675

jasmussen added a commit that referenced this pull request May 5, 2017
This fixes a regression I introduced in #623 (comment).
@jasmussen
Copy link
Contributor

Hah, sorry, deleting mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants