Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Site Editor to Edit site #62501

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Change Site Editor to Edit site #62501

merged 3 commits into from
Jun 12, 2024

Conversation

up1512001
Copy link
Member

@up1512001 up1512001 commented Jun 12, 2024 •
edited by amitraj2203
Loading

What?

Change site editor to edit site

Why?

Fixes: #62493

Screenshots or screencast

Screenshot 2024-06-12 at 11 02 15

@up1512001 up1512001 requested a review from spacedmonkey as a code owner June 12, 2024 05:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @up1512001! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 12, 2024
@up1512001 up1512001 mentioned this pull request Jun 12, 2024
Closed
@akasunil akasunil mentioned this pull request Jun 12, 2024
Closed
@akasunil akasunil added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 12, 2024
akasunil
akasunil approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@akasunil akasunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 12, 2024
@youknowriad youknowriad merged commit 1128ac0 into WordPress:trunk Jun 12, 2024
62 of 65 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 12, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@up1512001 @youknowriad @patil-vipul
Change Site Editor to Edit site (WordPress#62501)
7c2ae0f 
Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
ellatrix pushed a commit that referenced this pull request Jun 18, 2024
@up1512001 @youknowriad @ellatrix
Change Site Editor to Edit site (#62501)
536eec7 
Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
ellatrix pushed a commit that referenced this pull request Jun 18, 2024
@up1512001 @youknowriad @ellatrix
Change Site Editor to Edit site (#62501)
72115d8 
Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@ellatrix
Copy link
Member

I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 72115d8

@ellatrix ellatrix added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jun 18, 2024
ellatrix pushed a commit that referenced this pull request Jun 18, 2024
@up1512001 @youknowriad @ellatrix
Change Site Editor to Edit site (#62501)
a3e5a5c 
Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@ptesei ptesei mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akasunil akasunil akasunil approved these changes

@youknowriad youknowriad youknowriad approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 18.6
Development

Successfully merging this pull request may close these issues.

Restore "Edit site" in Gutenberg plugin
4 participants
@up1512001 @ellatrix @youknowriad @akasunil