Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Panel: Remove connections icon and fix padding #62542

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Save Panel: Remove connections icon and fix padding #62542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c8a3d7
Remove connections icon and fix padding
artemiomorales Jun 13, 2024
adbd3c2
Reuse Global Styles changes design for meta changes
artemiomorales Jun 14, 2024
7aadf9a
Update test
artemiomorales Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions packages/editor/src/components/entities-saved-states/entity-record-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
/**
* WordPress dependencies
*/
import { Icon, CheckboxControl, Flex, PanelRow } from '@wordpress/components';
import { CheckboxControl, PanelRow } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { useSelect } from '@wordpress/data';
import { store as coreStore } from '@wordpress/core-data';
import { decodeEntities } from '@wordpress/html-entities';
import { connection } from '@wordpress/icons';

/**
* Internal dependencies
Expand Down Expand Up @@ -60,18 +59,9 @@ export default function EntityRecordItem( { record, checked, onChange } ) {
/>
</PanelRow>
{ hasPostMetaChanges && (
<PanelRow>
<Flex className="entities-saved-states__post-meta">
<Icon
className="entities-saved-states__connections-icon"
icon={ connection }
size={ 24 }
/>
<span className="entities-saved-states__bindings-text">
{ __( 'Post Meta.' ) }
</span>
</Flex>
</PanelRow>
<ul className="entities-saved-states__changes">
<li>{ __( 'Post Meta.' ) }</li>
</ul>
) }
</>
);
Expand Down
13 changes: 0 additions & 13 deletions packages/editor/src/components/entities-saved-states/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,3 @@
margin-bottom: $grid-unit-05;
}
}

.entities-saved-states__post-meta {
margin-left: $grid-unit-30;
align-items: center;
}

.entities-saved-states__connections-icon {
flex-grow: 0;
}

.entities-saved-states__bindings-text {
flex-grow: 1;
}
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/various/publish-panel.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ test.describe( 'Post publish panel', () => {
await expect( publishPanel ).toBeVisible();

const postMetaPanel = publishPanel.locator(
'.entities-saved-states__post-meta'
'.entities-saved-states__changes'
);

await expect( postMetaPanel ).toBeVisible();
Expand Down
Loading