Fix: Include permission management on permanently delete, rename, and restore. #62754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +56 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jun 21, 2024
ellatrix
reviewed
Jun 21, 2024
| @@ -307,7 +307,7 @@ const trashPostAction = { | |||
| }, | |||
| }; | |||
|
|
|||
| function useTrashPostAction( postType ) { | |||
| function useCanUserEligibilityCheckPostType( postType, capability, action ) { | |||
| const registry = useRegistry(); | |||
| const { resource, cachedCanUserResolvers } = useSelect( | |||
| ( select ) => { | |||
There was a problem hiding this comment.
Could we avoid creating this subscription many times, and just do it once?
There was a problem hiding this comment.
Hi @ellatrix, I applied a change and now this PR does not add any store subscription.
|
When I remove the edit cap, I'm still seeing the Edit button: 
|
Hi @ellatrix, I think that's ok, the edit means open in the site editor, but in my tests the site editor does permission checks and for example, if you open a page there but don't have permission to edit you will not be able to change the page content. I guess if you have permission to change the template you may change the template but not the content. |
… restore post actions.
jorgefilipecosta
force-pushed
the
fix/expand-permission-checking-approach-from-trash-post-action-to-other-actions
branch
from
72b7f6e to
471e144
Compare
ellatrix
approved these changes
Jun 24, 2024
ellatrix
reviewed
Jun 24, 2024
| registry | ||
| .select( coreStore ) | ||
| .canUser( 'delete', resource, item.id ) | ||
| .canUser( capability, resource, item.id ) |
There was a problem hiding this comment.
I guess it doesn't really happen in the case, but the problem here is that isEligible will not be called if the user capability changes, right? So maybe all of these need to be precalculated/subscribed to at some point so the buttons re-render.
jorgefilipecosta
deleted the
fix/expand-permission-checking-approach-from-trash-post-action-to-other-actions
branch
ellatrix
added
Backported to WP Core
|
Handled in #62823. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands what was done in #62589 to other three actions where it makes sense: Permanently delete, rename, and restore post action.
Testing Instructions
I moved a page to the trash.
I added the following code to a PHP file:
I went to the trash page views and verified the permanently delete page action is unavailable.
I went to drafts view and verified the trash post action is still not available.
I added the following code to a PHP file:
I went to the drafts pages list and verified the ability to rename a page was not shown.
I went to the trash pages list and verified the ability to restore pages was not present.