Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport capability management 6.6. #62823

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Backport capability management 6.6. #62823

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d102d41
Backport capability management 6.6.
jorgefilipecosta Jun 25, 2024
6d1b061
Cherry pick Fix: Check permissions on duplicate pattern and template …
jorgefilipecosta Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 88 additions & 18 deletions packages/editor/src/components/post-actions/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/
import { external, trash, backup } from '@wordpress/icons';
import { addQueryArgs } from '@wordpress/url';
import { useDispatch, useSelect } from '@wordpress/data';
import { useDispatch, useSelect, useRegistry } from '@wordpress/data';
import { decodeEntities } from '@wordpress/html-entities';
import { store as coreStore } from '@wordpress/core-data';
import { __, _n, sprintf, _x } from '@wordpress/i18n';
Expand Down Expand Up @@ -155,6 +155,24 @@ const deletePostAction = {
},
};

function useCanUserEligibilityCheckPostType( capability, resource, action ) {
const registry = useRegistry();
return useMemo(
() => ( {
...action,
isEligible( item ) {
return (
action.isEligible( item ) &&
registry
.select( coreStore )
.canUser( capability, resource, item.id )
);
},
} ),
[ action, registry, capability, resource ]
);
}

const trashPostAction = {
id: 'move-to-trash',
label: __( 'Move to Trash' ),
Expand Down Expand Up @@ -323,12 +341,20 @@ const trashPostAction = {
},
};

function usePermanentlyDeletePostAction() {
function useTrashPostAction( resource ) {
return useCanUserEligibilityCheckPostType(
'delete',
resource,
trashPostAction
);
}

function usePermanentlyDeletePostAction( resource ) {
const { createSuccessNotice, createErrorNotice } =
useDispatch( noticesStore );
const { deleteEntityRecord } = useDispatch( coreStore );

return useMemo(
const permanentlyDeletePostAction = useMemo(
() => ( {
id: 'permanently-delete',
label: __( 'Permanently delete' ),
Expand Down Expand Up @@ -428,15 +454,20 @@ function usePermanentlyDeletePostAction() {
} ),
[ createSuccessNotice, createErrorNotice, deleteEntityRecord ]
);
return useCanUserEligibilityCheckPostType(
'delete',
resource,
permanentlyDeletePostAction
);
}

function useRestorePostAction() {
function useRestorePostAction( resource ) {
const { createSuccessNotice, createErrorNotice } =
useDispatch( noticesStore );
const { editEntityRecord, saveEditedEntityRecord } =
useDispatch( coreStore );

return useMemo(
const restorePostAction = useMemo(
() => ( {
id: 'restore',
label: __( 'Restore' ),
Expand Down Expand Up @@ -562,6 +593,11 @@ function useRestorePostAction() {
saveEditedEntityRecord,
]
);
return useCanUserEligibilityCheckPostType(
'update',
resource,
restorePostAction
);
}

const viewPostAction = {
Expand Down Expand Up @@ -723,6 +759,14 @@ const renamePostAction = {
},
};

function useRenamePostAction( resource ) {
return useCanUserEligibilityCheckPostType(
'update',
resource,
renamePostAction
);
}

const duplicatePostAction = {
id: 'duplicate-post',
label: _x( 'Duplicate', 'action label' ),
Expand Down Expand Up @@ -1031,18 +1075,32 @@ export const duplicateTemplatePartAction = {
};

export function usePostActions( { postType, onActionPerformed, context } ) {
const { postTypeObject } = useSelect(
const {
postTypeObject,
resource,
cachedCanUserResolvers,
userCanCreatePostType,
} = useSelect(
( select ) => {
const { getPostType } = select( coreStore );
const { getPostType, getCachedResolvers, canUser } =
select( coreStore );
const _postTypeObject = getPostType( postType );
const _resource = _postTypeObject?.rest_base || '';
return {
postTypeObject: getPostType( postType ),
postTypeObject: _postTypeObject,
resource: _resource,
cachedCanUserResolvers: getCachedResolvers()?.canUser,
userCanCreatePostType: canUser( 'create', _resource ),
};
},
[ postType ]
);

const permanentlyDeletePostAction = usePermanentlyDeletePostAction();
const restorePostAction = useRestorePostAction();
const trashPostActionForPostType = useTrashPostAction( resource );
const permanentlyDeletePostActionForPostType =
usePermanentlyDeletePostAction( resource );
const renamePostActionForPostType = useRenamePostAction( resource );
const restorePostActionForPostType = useRestorePostAction( resource );
const isTemplateOrTemplatePart = [
TEMPLATE_POST_TYPE,
TEMPLATE_PART_POST_TYPE,
Expand All @@ -1064,15 +1122,20 @@ export function usePostActions( { postType, onActionPerformed, context } ) {
! isPattern &&
duplicatePostAction
: false,
isTemplateOrTemplatePart && duplicateTemplatePartAction,
isPattern && duplicatePatternAction,
supportsTitle && renamePostAction,
isTemplateOrTemplatePart &&
userCanCreatePostType &&
duplicateTemplatePartAction,
isPattern && userCanCreatePostType && duplicatePatternAction,
supportsTitle && renamePostActionForPostType,
isPattern && exportPatternAsJSONAction,
isTemplateOrTemplatePart ? resetTemplateAction : restorePostAction,
isTemplateOrTemplatePart
? resetTemplateAction
: restorePostActionForPostType,
isTemplateOrTemplatePart || isPattern
? deletePostAction
: trashPostAction,
! isTemplateOrTemplatePart && permanentlyDeletePostAction,
: trashPostActionForPostType,
! isTemplateOrTemplatePart &&
permanentlyDeletePostActionForPostType,
].filter( Boolean );
// Filter actions based on provided context. If not provided
// all actions are returned. We'll have a single entry for getting the actions
Expand Down Expand Up @@ -1129,16 +1192,23 @@ export function usePostActions( { postType, onActionPerformed, context } ) {
}

return actions;
// We are making this use memo depend on cachedCanUserResolvers as a way to make the component using this hook re-render
// when user capabilities are resolved. This makes sure the isEligible functions of actions dependent on capabilities are re-evaluated.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [
isTemplateOrTemplatePart,
isPattern,
postTypeObject?.viewable,
permanentlyDeletePostAction,
restorePostAction,
permanentlyDeletePostActionForPostType,
restorePostActionForPostType,
renamePostActionForPostType,
trashPostActionForPostType,
onActionPerformed,
isLoaded,
supportsRevisions,
supportsTitle,
context,
userCanCreatePostType,
cachedCanUserResolvers,
] );
}
Loading