Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra scrollbar when a popover extends past the viewport. #62894

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Fix extra scrollbar when a popover extends past the viewport. #62894

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2073fb
Fix extra scrollbar when a popover extends past the viewport.
tellthemachines Jun 27, 2024
8aac4e1
Scope overflow only to iframed canvas
tellthemachines Jun 27, 2024
81c8f6b
revert other change
tellthemachines Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/interface/src/components/interface-skeleton/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,9 @@ html.interface-interface-skeleton__html-container {
display: flex;
flex-direction: column;

// On Mobile the header is fixed to keep HTML as scrollable.
// Beyond the medium breakpoint, we allow the sidebar.
// The sidebar should scroll independently, so enable scroll here also.
overflow: auto;
// Hide the Y overflow to avoid an extra scrollbar when an active popover
// extends vertically beyond the viewport.
overflow-y: hidden;

// On Safari iOS on smaller viewports lack of a z-index causes the background
// to "bleed" through the header.
Expand Down
Loading