-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List: maintain nested list on parent item removal #62949
Conversation
Size Change: +25 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in bd74fd6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9708377232
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: a530166 |
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
What?
Best reviewed without whitespace changes.
Currently, when removing a parent item, the nested list items are appended at the bottom of the list instead of preserved at the position.
Why?
Note that right now, in trunk, not only does the indentation disappear, the indented list item is also moved to the bottom! If you have a long nested list, it feels like your content disappears.
How?
Testing Instructions
See GIF. Create this setup:
And press Backspace twice from the empty list item.
Testing Instructions for Keyboard
Screenshots or screencast