-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post featured image: add example of the block #63011
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in bb18747. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9796999474
|
This PR needs #63177 to land for the GS previews to work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview is a bit lacklustre when there's no context, but that's a separate issue.
48deac9
to
a338979
Compare
* add featured image block preview * show the preview on Global Styles * Update packages/block-library/src/post-featured-image/block.json * removed forced size
What?
Add an example to the
core/post-featured-image
block.Part of #30029
Why?
Because it was showing empty before
How?
By defining a viewport width size for the example
Testing Instructions
Create a post and add a featured image to it.
Open the block inserter and search for the featured image block, hover over it and you'll see the example. It should show the current post's featured image.
Testing Instructions for Keyboard
Screenshots or screencast