Compat: Update HTML API with changes from 6.6 #63089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added
Backport from WordPress Core
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dmsnell
commented
Jul 3, 2024
| case '-NAV': | ||
| case '-SEARCH': | ||
| case '-SECTION': | ||
| case '-SUMMARY': |
There was a problem hiding this comment.
I apparently added code from the 6.5 branch when I initially added this file.
|
Flaky tests detected in 29797ed. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9779966065
|
ockham
approved these changes
Jul 3, 2024
dmsnell
added a commit
that referenced
this pull request
Jul 3, 2024
Updates the HTML API components in the compatability layer with updates from each of the 6.4, 6.5, and 6.6 branches from Core. Notably, because of the breaking change in 6.5 to the `WP_HTML_Span` and `WP_HTML_Text_Replacement` classes, which changed the range format from `(start, end)` to `(start, length)`, the 6.6 classes still reference the `Gutenberg_HTML_Span_6_5` and `Gutenberg_HTML_Text_Replacement_6_5` substitutions. While updating it was noticed that the 6.4 compatability code accidentally pulled in updates from the 6.5 branch for the HTML Processor. These additions have been removed for the sake of closer correspondance with the Core code. Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
dmsnell
force-pushed
the
compat/add-html-api-6-6
branch
from
29797ed to
15bc8c0
Compare
dmsnell
added a commit
that referenced
this pull request
Jul 3, 2024
Updates the HTML API components in the compatability layer with updates from each of the 6.4, 6.5, and 6.6 branches from Core. Notably, because of the breaking change in 6.5 to the `WP_HTML_Span` and `WP_HTML_Text_Replacement` classes, which changed the range format from `(start, end)` to `(start, length)`, the 6.6 classes still reference the `Gutenberg_HTML_Span_6_5` and `Gutenberg_HTML_Text_Replacement_6_5` substitutions. While updating it was noticed that the 6.4 compatability code accidentally pulled in updates from the 6.5 branch for the HTML Processor. These additions have been removed for the sake of closer correspondance with the Core code. Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
dmsnell
force-pushed
the
compat/add-html-api-6-6
branch
from
15bc8c0 to
d8d6efa
Compare
Updates the HTML API components in the compatability layer with updates from each of the 6.4, 6.5, and 6.6 branches from Core. Notably, because of the breaking change in 6.5 to the `WP_HTML_Span` and `WP_HTML_Text_Replacement` classes, which changed the range format from `(start, end)` to `(start, length)`, the 6.6 classes still reference the `Gutenberg_HTML_Span_6_5` and `Gutenberg_HTML_Text_Replacement_6_5` substitutions. While updating it was noticed that the 6.4 compatability code accidentally pulled in updates from the 6.5 branch for the HTML Processor. These additions have been removed for the sake of closer correspondance with the Core code. Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
dmsnell
force-pushed
the
compat/add-html-api-6-6
branch
from
d8d6efa to
750f1db
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Updates the HTML API components in the compatability layer with updates from each of the 6.4, 6.5, and 6.6 branches from Core. Notably, because of the breaking change in 6.5 to the `WP_HTML_Span` and `WP_HTML_Text_Replacement` classes, which changed the range format from `(start, end)` to `(start, length)`, the 6.6 classes still reference the `Gutenberg_HTML_Span_6_5` and `Gutenberg_HTML_Text_Replacement_6_5` substitutions. While updating it was noticed that the 6.4 compatability code accidentally pulled in updates from the 6.5 branch for the HTML Processor. These additions have been removed for the sake of closer correspondance with the Core code. Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ports code from WordPress 6.6 into
lib/compat/wordpress-6.6.Ports code from WordPress 6.5 into
lib/compat/wordpress-6.5.Ports code from WordPress 6.4 into
lib/compat/wordpress-6.4.Because of the breaking change in 6.5 of the Span and Text Replacement, the 6.6 functions still refer to
Gutenberg_HTML_Span_6_5andGutenberg_HTML_Text_Replacement_6_5.Why?
Ensures that code relying on functionality in the HTML API will work on Gutenberg sites running on older WordPress versions.
How?
Copies files from Core in the
6.6branch and replacesWP_classes that have updates in 6.6 with theirGutenberg_counterparts.Testing Instructions
Let the tests run. Since nothing calls these classes yet the only thing that should matter is whether a site loads with the plugin installed.