Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Overlay caption w. text-shadow. #63471
Try: Overlay caption w. text-shadow. #63471
Changes from 6 commits
01e744b
9b62ee9
5f3d3a9
4ca916c
a489d99
2cc9623
171f791
f8cf8e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a non-blocker suggestion.
Because
scrollbar-gutter: stable both-edges
has been applied to thefigcaption
, the padding on the left and right looks wider, we may want to make it a little smaller.Below is what it looks like on my environment, but how does it look on yours?
padding: 1em
:padding: 1em 0.5em
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't disagree, though since this PR already touches a fair bit of CSS, I wonder if it's not best to do this separately?
Thank you again for the thorough reviews!