Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Do not render bulk actions Dropdown if no actions are available #63575

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Jul 15, 2024

What?

Small follow up of: #63473

Testing instructions

If have no item selected and click the bulk actions button in Data Views lists, we should render an empty Dropdown and the separator.

@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Package] DataViews /packages/dataviews labels Jul 15, 2024
@ntsekouras ntsekouras self-assigned this Jul 15, 2024
@ntsekouras ntsekouras changed the title DataViews: Do not render bulk actions Dropdown if no actions are ava… DataViews: Do not render bulk actions Dropdown if no actions are available Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ntsekouras ntsekouras requested a review from Mamaduka July 15, 2024 17:19
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense ✅

@ntsekouras ntsekouras merged commit ac29b27 into trunk Jul 16, 2024
69 checks passed
@ntsekouras ntsekouras deleted the fix/bulk-actions-empty-dropdown-dataviews branch July 16, 2024 06:17
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 16, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
…ilable (WordPress#63575)

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] DataViews /packages/dataviews [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants