-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom Out: Fix error when block is null #63709
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I believe #63642 is also looking at this issue. |
Size Change: +1 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Authored that. Just want to say the core difference between the two is that one fixes the problem higher in the component tree with the advantage being the zoom out toolbar won’t even render when the block is null. The first attempt I made was pretty much this. |
Closing in favour of #63642 |
What?
Fixes #63456, an error when deselecting a block in zoom out mode.
Why?
Stops an error being thrown.
How?
Don't assume the
getBlock
always returns an object.Testing Instructions
Screenshots or screencast
The error in trunk: