Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Z-Index Issue for Link Options in Block Editor #63834

Conversation

dhananjaykuber
Copy link
Contributor

Fixes #63795

What?

This PR adds a z-index to the .editor-visual-editor class to prevent link options from being hidden when editing text at the bottom of the page.

Why?

Currently, when editing text at the bottom of the page in the new block editor, the link options can be hidden behind other elements (such as SEO options). This issue occurs because the .editor-visual-editor class lacks a z-index property. Adding a z-index resolves this problem and improves the user experience when working with links in the editor.

How?

The fix involves adding a z-index: 20 to the .editor-visual-editor class in the appropriate CSS file. This ensures that the editor's content, including link options, appears above other page elements.

Testing Instructions

  1. Go to "Add New Post"
  2. Add a long block of text that extends beyond the initial viewport
  3. Scroll to the bottom of the text
  4. Try to add or edit a link in the text at the bottom of the page
  5. Verify that the link options are visible and not hidden behind other page elements

Screenshots or screencast

Screenshot 2024-07-23 at 11 06 55 AM

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @rgerhards, @83pixel.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: rgerhards, 83pixel.

Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano
Copy link
Contributor

Hi @dhananjaykuber,

This issue has been resolved in #63939. Of course, you have been added as a co-author to the props.

I would like to close this PR, but thank you for your efforts!

@t-hamano t-hamano closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New block editor z-index issue. Link options are hidden at the bottom of the page
2 participants