Update template description in table layout #63942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -7 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Jul 26, 2024
t-hamano
approved these changes
Jul 26, 2024
| @@ -51,8 +51,17 @@ | |||
| } | |||
| } | |||
|
|
|||
| .dataviews-view-table { | |||
| .page-templates-description { | |||
| margin-bottom: $grid-unit-10; | |||
There was a problem hiding this comment.
I think it would be simpler to move this style here. I think the selector .page-templates-description is enough.
There was a problem hiding this comment.
If we do this then the margin will also be applied in Grid and List layouts, which we do not want.
There was a problem hiding this comment.
Ah, that's true. How about the following? It may be a matter of preference.
.page-templates-description {
max-width: 50em;
text-wrap: balance; // Fallback for Safari
text-wrap: pretty;
.dataviews-view-table & {
margin-bottom: $grid-unit-10;
}
}There was a problem hiding this comment.
Oh sure, I always forget about that selector.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates some styling details relating to template descriptions in table layout.
Why?
Improves legibility. Currently descriptions will fill the cell which makes the text troublesome to read on large screens.
How?
max-widthto.page-templates-description.$maximum-text-widthvar in_variables.scssfor this purpose as it will likely have applications elsewhere. cc @WordPress/gutenberg-components for thoughts on that.text-wrap: prettyto take care of typographical widows..page-templates-descriptionin table layout to centrally align the title + description in the cell.Testing Instructions
Before
After