Editor: Enhance post URL UI #64231
Open
Editor: Enhance post URL UI #64231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
t-hamano
force-pushed
the
enhance-post-url-ui
branch
from
a48c6ec to
b502e95
Compare
|
Size Change: -105 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
enhance-post-url-ui
branch
from
b502e95 to
7cf488a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you for working on this. I know we've gone around the block a few times on these details, it's been a tricky one to get right. Generally, I agree with the changes here. But I have to say the design feels a bit rough to me. The worst offender is the URL and copy button. When the URL is short the copy button is not obviously attached to anything, it's just floating out in space. With a longer url that wraps the alignment becomes awkward. Before spending time exploring other solutions I feel compelled to ask; are they necessary? It's already possible to view the page by clicking the dedicated icon button in the top bar, or via the actions menu, both of which feel more natural than this UI imo. 
I don't know how useful the copy action is, but it doesn't seem particularly helpful to me. This UI would be much cleaner if it only contained the input, and I don't really see much drop-off in utility. I suppose the only drawback is that you can't see the full URL, but since you can only edit the slug I don't know if that's all that important? |
|
Thanks for the review! I imagine one use case for copying the permalink would be to embed it in another post, or to make it easier to paste into some other document. Of course, even without this button, users can still copy the permalink in a few ways. In any case, I think the full URL needs to be visible somewhere in the editor. |
|
I'd like to note there's already a previous PR #63669 which aims to fix #61196. This PR partially overlaps with that pre-existing PR. I'd appreciate some better coordination as submitting multiple PRs for the same issue without coordinating with other contributors doesn't appear to be the best way to collaborate in an open source project. Also, worth noting that after #64053 a long URL / slug is now truncated. I kindly disagree with that change. It defeats the purpose of this UI, which is to show the full URL or slug. #63669 removes the truncation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61196, #63700
Related to #63669, #63706
What?
This PR improves the labels and layout of the post URL UI so that all text, fields, and buttons convey their exact meaning.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Make sure that your screen reader announces the appropriate information when a button or input field receives focus or a popover is opened.
Screenshots or screencast
Permalink Structure: Plain
Permalink Structure: Month and name
Permalink Structure: Post name
Reading text with NVDA
d851654314d689c318d787c8362b7e71.mp4
Note
When merging this PR, please remember to include in the props all the contributors who worked on solving similar issues: