Quick edit: add Date as field and datetime as field type
#64267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
|
Looking at the video, I feel like we're missing a label here. I think in the default "form" renderer (the default one we're using until now), all the fields should look like we're in regular form and have some consistency. |
|
Size Change: +352 B (+0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Set it to draft, as this is still in progress: fixing some types, adding tests, date format, form design, etc. |
oandregal
force-pushed
the
add/quick-edit-date
branch
from
e40a0ea to
e841c71
Compare
oandregal
commented
Aug 6, 2024
oandregal
commented
Aug 6, 2024
| }; | ||
| const [ edits, setEdits ] = useState( {} ); | ||
| const [ edits, setEdits ] = useState( initialEdits ); |
There was a problem hiding this comment.
This makes sure that the dataform has access to the previous item. It was always an empty object for the onChange event handler. The setEdits( {} ) below also triggered a re-render of the DataForm on submit.
oandregal
changed the title
date as field and field typedatetime as field type
|
@jameskoster I've pushed the "datetime" type field as two separate inputs ( Note that I used the HTML input components directly:
Using the browser components directly has its disadvantages, as we'd need to make sure every style provided by 
|
1 task
|
There's a related conversation about this at #64299 (comment) |
ntsekouras
reviewed
Aug 6, 2024
ntsekouras
reviewed
Aug 6, 2024
I think using |
Based on this feedback and the fact that we are going to have two form layouts as per #64299 I've pushed the following changes:
Gravacao.do.ecra.2024-08-07.as.08.38.13.mov |
|
This is ready for a new round of feedback/approval. |
youknowriad
reviewed
Aug 7, 2024
This reverts commit 27ffe45.
oandregal
force-pushed
the
add/quick-edit-date
branch
from
02f1e35 to
69946cc
Compare
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #59745 #63624
What?
Adds the "Date" field in quick edit as a
datetimetype.Gravacao.do.ecra.2024-08-07.as.08.38.13.mov
How?
This PR introduces a
datetimefield type definition to be used by the "Date" field.Testing Instructions