Latests Posts: Used ToggleGroupControl instead for Image alignment #64352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitraj2203
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +71 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
mirka
reviewed
Aug 7, 2024
t-hamano
reviewed
Aug 8, 2024
|
Thanks for the Update! I overlooked it, but I think we need to use the "position" alignment icon (
Additionally, you might want to add |
|
Flaky tests detected in b53a92c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10295841291
|
Thanks. Updated the PR. |
mirka
approved these changes
Aug 8, 2024
|
LGTM! Let's 🚀 9c2224c8a64de2b0afebfb1251e36a1e.mp4 |
t-hamano
added
the
props-bot
github-actions
bot
removed
the
props-bot
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
…64352) * Used ToggleGroupControl instead of BlockAlignmentToolbar * Addressed feedback * Use position icons instead of align * Remove isBlock prop from ToggleGroupControl Co-authored-by: amitraj2203 <amitraj2203@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #64350
Why?
See this comment
How?
Used ToggleGroupControl for Image alignment
Testing Instructions
Latest Posts blockDisplay featured imageImage alignmentsettingsScreenshots or screencast