Drag & drop: allow direct block drag #64461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Feature] Drag and Drop
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +23 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Tried testing this out and found it to be quite buggy in a few ways:
buggy.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #63267.
Simply enables the native browser dragging, while setting data transfer to be the block.
Maybe eventually we'd want to use a different technique to have more control over what the clone is, and what content is left in place, but I think this is a great start to iterate from.
Why?
It's just more intuitive to drag and drop blocks directly if possible.
How?
We leverage native draggable. Text and images are draggable by default, so we don't need to do anything special. We just need to set the correct data transfer info.
Outside of that,
draggableneeds to be explicitly enabled. For example, a list item is draggable if you select all the text contents, but by also making the block itselfdraggable, the user can grab the list item by the bullet (see screenshot).The same thing can be used for quote, button, maybe more.
Testing Instructions
Try dragging text-based blocks, list items, quotes, images etc.
Testing Instructions for Keyboard
Screenshots or screencast