Ariakit: Update to v0.4.10 #64637
Merged
Ariakit: Update to v0.4.10 #64637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +69 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Aug 20, 2024
I'm planning to do it in a follow-up PR. |
ciampo
reviewed
Aug 20, 2024
|
Now that the dependency was correctly updated, we'll see some failures related with the |
|
Adding |
Yup, seems like it might be coming from here: ariakit/ariakit#4018 |
I'm surprised that the changed you linked affected us, since we never set Basically, it's unexpected to me that we have to set it explicitly, since I thought it already always defaulted to (cc @diegohaz in case he can clarify why this is happening) |
ciampo
reviewed
Aug 20, 2024
| @@ -220,6 +220,7 @@ const UnforwardedTabPanel = ( | |||
| showTooltip={ !! tab.icon } | |||
| /> | |||
| } | |||
| accessibleWhenDisabled | |||
There was a problem hiding this comment.
We may to have to do the same for the Tab component
diff --git a/packages/components/src/tabs/tab.tsx b/packages/components/src/tabs/tab.tsx
index e1aa85c636..8ab67e1ca9 100644
--- a/packages/components/src/tabs/tab.tsx
+++ b/packages/components/src/tabs/tab.tsx
@@ -26,6 +26,7 @@ export const Tab = forwardRef<
const instancedTabId = `${ instanceId }-${ tabId }`;
return (
<StyledTab
+ accessibleWhenDisabled
ref={ ref }
store={ store }
id={ instancedTabId }
Agreed it's surprising - it is also documented to be |
|
Note that ariakit/ariakit#4018 seems to be specifically removing the default |
Yes! 🤦🏽♂️ That was unintentional. |
|
Here's a quick PR to reverse it with as little changes as needed: ariakit/ariakit#4056 cc @diegohaz |
|
Flaky tests detected in 3128041. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10470709928
|
tyxla
added
the
[Status] Blocked
|
Currently blocked by ariakit/ariakit#4056 Will resume when there's a minor version that fixes the default of |
diegohaz
added a commit
to ariakit/ariakit
that referenced
this pull request
Aug 20, 2024
This suggests reverting the unintended changes caused by #4018 See WordPress/gutenberg#64637 (comment) --------- Co-authored-by: Haz <hazdiego@gmail.com>
|
OK, I've updated to the latest version with the Should be ready for another look! |
tyxla
removed
the
[Status] Blocked
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* Ariakit: Update to v0.4.9 * CHANGELOG * Deduplicate some ariakit dependencies * TabPanel: keep tabs accessible when disabled * Tab: enable accessibleWhenDisabled specifically * Bump to 0.4.10 * Revert "TabPanel: keep tabs accessible when disabled" This reverts commit 44ede08. * Revert "Tab: enable accessibleWhenDisabled specifically" This reverts commit 3128041. * Fix CHANGELOG Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> --------- Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: diegohaz <hazdiego@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates
@ariakit/reactto the latestv0.4.10.I'm planning to use the new APIs in subsequent PRs.
Why?
Mostly to consider a few fixes and the new
useStoreStateAPI that helps with React Compiler compatibility. Will be done in another PR.How?
Just updating the dependency and resolving test failures where necessary.
Testing Instructions
Composite,CustomSelectControl,DropdownMenuV2,RadioGroup,TabPanel,Tabs,ToggleGroupControl,Tooltip,Toolbar)Testing Instructions for Keyboard
Verify all the above components are navigable with keyboard navigation like before.
Screenshots or screencast