Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: hide sort direction control if there is no sortable fields #64817

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

oandregal
Copy link
Member

Fixes #64816

Copy link

github-actions bot commented Aug 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal self-assigned this Aug 27, 2024
@oandregal oandregal added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Aug 27, 2024
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@oandregal oandregal enabled auto-merge (squash) August 27, 2024 08:49
@oandregal oandregal changed the title Hide sort direction control if there is no sortable fields DataViews: hide sort direction control if there is no sortable fields Aug 27, 2024
@oandregal oandregal merged commit bee5937 into trunk Aug 27, 2024
69 of 70 checks passed
@oandregal oandregal deleted the fix/dataviews-sort-direction branch August 27, 2024 08:54
@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 27, 2024
@oandregal oandregal added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Aug 27, 2024
@oandregal
Copy link
Member Author

oandregal commented Aug 27, 2024

@artemiomorales I tagged this one as "backport to gutenberg RC" and modified the milestone to 19.1, in case there's a chance it can be part of that release. This is a fix for a new feature introduced in 19.1 (redesigned view config in dataviews).

artemiomorales pushed a commit that referenced this pull request Aug 28, 2024
…#64817)

Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
cbravobernal added a commit that referenced this pull request Aug 28, 2024
* DataViews: Add missing styles and remove opinionated ones for generic usage (#64711)

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

* Shuffle: Don't call '__experimentalGetAllowedPatterns' for every block (#64736)


Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: wpsoul <wpsoul@git.wordpress.org>

* DataViews: hide sort direction control if there is no sortable fields (#64817)

Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>

* Block Bindings: Refactor utils file. (#64740)

* Refactor block binding utils

* Add security checks

Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>

* Interactivity API: Fix computeds without scope in Firefox (#64825)

* Replace NO_SCOPE symbol with an object

* Update changelog

Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: Marc-pi <mdxfr@git.wordpress.org>

---------

Co-authored-by: Riad Benguella <benguella@gmail.com>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: wpsoul <wpsoul@git.wordpress.org>
Co-authored-by: André <583546+oandregal@users.noreply.github.com>
Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: Carlos Bravo <37012961+cbravobernal@users.noreply.github.com>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: David Arenas <david.arenas@automattic.com>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: Marc-pi <mdxfr@git.wordpress.org>
@artemiomorales
Copy link
Contributor

I just cherry-picked this PR to the release/19.1 branch to get it included in the next release: #64876

@artemiomorales artemiomorales removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Aug 28, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
…WordPress#64817)

Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataViews: sort asc/desc in view config should be hidden if no field is sortable
3 participants