Post publish upload media dialog: handle upload errors #64823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Nice! The only change I'd make is I wouldn't use the red alert color, so you can delete that CSS. Otherwise, 👍 👍 |
|
Thank you, @jasmussen! 👍 I've deleted the CSS, as you suggested. Do you feel strongly about keeping vs dropping the classname? |
|
Size Change: +35 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
sgomes
added
[Type] Enhancement
|
I'd lean towards dropping the classname. |
jasmussen
approved these changes
Aug 27, 2024
|
Flaky tests detected in 2c4ad77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10576658487
|
Done, thanks again! |
Mamaduka
reviewed
Aug 27, 2024
| @@ -114,6 +116,7 @@ export default function PostFormatPanel() { | |||
| resolve(); | |||
| }, | |||
| onError() { | |||
| setHadUploadError( true ); | |||
There was a problem hiding this comment.
This only catches errors from media upload; we also need to catch errors for window.fetch.
There was a problem hiding this comment.
This promise chain is getting fun 😄
I added a catch-all to the end of each individual upload. That should catch any errors / rejections, whether they come from the window.fetch or one of the later steps.
How does that look?
|
Thank you for the review, @Mamaduka! 👍 Unfortunately it seems we'll need yet another PR, since there seems to be a race condition in media uploads, where they sometimes end up sharing an ID 😞 Still investigating that one, will follow up with bug report and a fix too, if I can manage it. |
|
@sgomes, that's not good. Feel free to ping if you need any help. |
|
FYI, I'm still investigating the race condition, but it seems to be happening on the server somewhere (either the REST API or a bit deeper). I'll add a link here once I have something. |
|
Thanks, @sgomes! Side note: Gutenberg merge commits now require including props generated by the props-bot at the end of the merge commit. |
Oh, sorry about that 😞 I missed the bit where it needs to be done manually. |
|
For anyone following this thread, I created #64899 for the race condition I briefly mentioned above. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* Post publish upload media dialog: handle upload errors * Change text color * Drop unused classname * Add catch-all for any errors during upload * Remove redundant setHadUploadError call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds minimal information to the post publish upload media dialog when an upload error takes place. Previously, it would simply show the upload button again.
This is a follow-up to #64741.
Why?
It's important to communicate that something went wrong during the upload process.
How?
Some simple text is displayed until the upload is tried again. Here is a video of how this looks:
Error.on.upload.mov
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast