Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropdownMenuV2: update animation #64868

Merged
merged 12 commits into from
Sep 2, 2024
Merged

DropdownMenuV2: update animation #64868

merged 12 commits into from
Sep 2, 2024

Commits on Sep 2, 2024

  1. DropdownMenuV2: update animation specs

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    68c2f85 View commit details
    Browse the repository at this point in the history

  2. Swap inner and outer wrappers so that role="menu" is direct parent of… 

    … menuitems
    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d53dbd0 View commit details
    Browse the repository at this point in the history

  3. CHANGELOG

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    ae565ed View commit details
    Browse the repository at this point in the history

  4. Using currentPlacement instead of placement

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    18ba543 View commit details
    Browse the repository at this point in the history

  5. Move z-index styles to inner wrapper

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6396cb1 View commit details
    Browse the repository at this point in the history

  6. Consolidate animation styles

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    303fdbc View commit details
    Browse the repository at this point in the history

  7. Tweak outer wrapper scale factor

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    02633b4 View commit details
    Browse the repository at this point in the history

  8. Remove will-change as it seems to cause glitchiness

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    dd663d6 View commit details
    Browse the repository at this point in the history

  9. Add exit animation 

    - Refactor from CSS animation to transition
- Use `[data-enter]` and `[data-leave]` ariakit attributes
- Move CSS comments inline
    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5ad3a10 View commit details
    Browse the repository at this point in the history

  10. Remove unuesed import

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    3653700 View commit details
    Browse the repository at this point in the history

  11. Update packages/components/src/dropdown-menu-v2/styles.ts 

    Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
    @ciampo @tyxla
    ciampo and tyxla committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a6f93b3 View commit details
    Browse the repository at this point in the history

  12. Change out animation duration to 200ms

    @ciampo
    ciampo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c26c72e View commit details
    Browse the repository at this point in the history