Scripts: Make React Fast Refresh work with multiple blocks #64924
+48
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Tool] WP Scripts
gziolo
commented
Aug 30, 2024
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
gziolo
commented
Aug 30, 2024
gziolo
force-pushed
the
update/react-fast-refresh-multiple-entries
branch
from
32b640e to
4010850
Compare
gziolo
commented
Dec 3, 2024
gziolo
commented
Dec 3, 2024
|
Flaky tests detected in 3d031a4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12135432278
|
gziolo
force-pushed
the
update/react-fast-refresh-multiple-entries
branch
from
b024d2d to
cf97a83
Compare
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
changed the title
This was referenced Dec 3, 2024
sirreal
approved these changes
Dec 3, 2024
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
…#64924) * Scripts: Make React Fast Refresh Work with multiple blocks * Properly pass the unique name for the build and updates test snapshots * Apply suggestions from code review * Add changelog entry Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Scripts: Make React Fast Refresh Work with multiple blocks * Properly pass the unique name for the build and updates test snapshots * Apply suggestions from code review * Add changelog entry Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #25188.
Follow-up for #28273.
Related comments:
wp-scripts start --hotworks perfectly fine with a single entry point that contains all the logic used in the editor. It starts to break if multiple entry points get loaded in the project editor. A perfect example would be a plugin with numerous blocks where each of them loads JavaScript separately. The workaround so far was to bundle all JavaScript code for the editor together. However, it isn’t always the most efficient approach. Besides, it would be great if that worked out of the box, no matter how configured the entry points were.Screenshot from #25188 (comment):
Why?
Source: https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/main/docs/TROUBLESHOOTING.md#component-not-updating-with-bundle-splitting-techniques
How?
In the development mode when React Fast Refresh is enabled, there is a shared runtime created. This way it acts as en entry point for existing scripts that orchestrates all updates with hot-module replacement for React code.
Known Issues
It looks like CSS support for hot-module reloading doesn't work anymore in
trunkand with this branch. I will investigate this separately as it is unrelated to these changes. I found an issue that seems very similar webpack-contrib/mini-css-extract-plugin#1089. My debugging session pointed me in the direction thatmini-css-extract-pluginis unable to correctly match the url of CSS file in thelinktags with these coming from hot reload. The reason seems to originate from the fact that the asset version appended to the url confuses the plugin.Testing Instructions
Create a new test plugin with more than one block. You can do it as follows:
npx wp-create-block my-plugin --no-wp-scripts.npx wp-create-block my-block --no-pluginis helpful here.cd my-plugin ../node_modules/.bin/wp-scripts start --hot