Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use nested blocks for quotes (#6054)" #6501

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

ellatrix
Copy link
Member

This reverts commit 853900d.

@ellatrix ellatrix requested a review from a team April 30, 2018 12:34
@jasmussen
Copy link
Contributor

Note that the citation issue with the quote that has nested blocks is not unique to this block, and you can actually surface the cite still, just have to select the quote block. This is hard, because the block breadcrumb toolbar hasn't worked as intended. But I'm working on a new approach to make it simpler to select blocks and their parents in try/alternate-hover-approach (that branch is waaay WIP), but essentially that would mean we could go back to having nested blocks in the quote.

Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reverting. Let's wait until all the stars align (design and UX, more technical support for all things nested) so we can get this back in.

@ellatrix ellatrix merged commit 230ad0d into master Apr 30, 2018
@ellatrix ellatrix deleted the revert/quote-nested-blocks branch April 30, 2018 13:24
@mcsf mcsf added this to the 2.8 milestone Apr 30, 2018
ellatrix added a commit that referenced this pull request May 1, 2018
@ellatrix ellatrix mentioned this pull request May 1, 2018
4 tasks
ellatrix added a commit that referenced this pull request May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants