Inserter: Fix subtle media insertion error #65057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +224 B (+0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
|
This is the right change. The focus recovery is still required when inserting a block that will end up having a filtered list, like inserting a list block that rerenders the inserter and focus moves to the first item in the rerendered inserter (list item block). |
|
@jeryj, by "filtered list", do you mean restricted by "allowed blocks"? When inserting the List block, the focus stays and doesn't move to the first item in the rerendered inserter (List Item). ScreenshotCleanShot.2024-09-04.at.19.27.40.mp4 |
|
It does move for me. I'm in the site editor though with a lot of blocks, so it might be due to the slow rerender. It may also be that my cursor is within the content vs in the inserter which is having that odd issue. list.block.item.focus.mov |
|
I'm getting the same results in the post editor with 30+ blocks (you can use a Demo post); the cursor is within the content. So it seems we've regressions or inconsistent behavior between editors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an error in the inserter when inserting an image (see screenshot below).
Why?
Just resolving an error.
Discovered while testing #65043.
How?
We're ensuring the blocks tab exists before attempting to resolve the previously lost focus.
Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast