Block Editor: Use the tooltip from a button in 'ButtonBlockAppender' #65113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Sep 6, 2024
| @@ -76,20 +76,11 @@ function ButtonBlockAppender( | |||
| // eslint-disable-next-line no-restricted-syntax | |||
| disabled={ disabled } | |||
| label={ label } | |||
| showTooltip | |||
There was a problem hiding this comment.
The isToggleButton || hasSingleBlockType condition was always true.
Mamaduka
commented
Sep 6, 2024
Comment on lines
-80
to
-82
| { ! hasSingleBlockType && ( | ||
| <VisuallyHidden as="span">{ label }</VisuallyHidden> | ||
| ) } |
There was a problem hiding this comment.
I think this was a leftover when the button appender had a visual label. The button has an aria-label, so visually hidden text shouldn't be necessary for a11y.
cc @afercia
|
Size Change: -47 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 53f8635. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10735021914
|
|
Thanks for testing, @tyxla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the
ButtonBlockAppenderto use theButtonbuilt-in feature for tooltips. It also removes the unnecessaryVisuallyHiddencomponent.Why?
Reduces complexity in the component by removing redundant logic.
Testing Instructions
Blocks for testing
Testing Instructions for Keyboard
Same.
Screenshots or screencast