Fix image block crash #65222
Merged
Fix image block crash #65222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
requested review from
kevin940726,
andrewserong and
aaronrobertshaw
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
const [ resizeListener, sizes ] = useResizeObserver();P.S. The above syntax seems to be implicitly deprecated by #64943. It may be possible to refactor it in the future, including the Image block: gutenberg/packages/compose/src/hooks/use-resize-observer/index.ts Lines 87 to 90 in 6a60081 |
kevin940726
approved these changes
Sep 11, 2024
|
Too fast! ❤️ I'll close mine #65222 |
ramonjd
approved these changes
Sep 11, 2024
|
Thanks for the review!
We discussed this in #64320 but found it difficult to integrate 😅 please see this comment. |
|
Thanks for fixing this so quickly! 🙇 |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #64320
What?
This PR fixes a crash that occurs when an Image block is inserted.
Why?
This is because two PRs were merged at almost the same time 😅
In #64320, a new
useResizeObserverhook was added to improve the Image block.This PR itself works correctly, but right after this PR was merged, #64819 was merged. In #64819, the
useResizeObserverhook was removed, so the import statement no longer exists, causing a critical error.Testing Instructions
Make sure you can insert the image block correctly.