Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox Control: Add placeholder attribute #65254

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Conversation

zaguiini
Copy link
Member

What?

Title.

Why?

Increase UX of the Combobox control by making possible to specify a placeholder for it.

How?

Accepts a placeholder prop and passes it to the <TokenInput /> element.

Testing Instructions

Open Storybook and pick the Components > ComboboxControl component. You should see the placeholder applied.

Screenshots or screencast

image

@zaguiini zaguiini added [Feature] UI Components Impacts or related to the UI component system Storybook Storybook and its stories for components labels Sep 12, 2024
@zaguiini zaguiini self-assigned this Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: zaguiini <zaguiini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@zaguiini zaguiini added [Type] Feature New feature to highlight in changelogs. [Package] Components /packages/components and removed [Feature] UI Components Impacts or related to the UI component system labels Sep 12, 2024
@zaguiini zaguiini requested review from mirka and a team September 12, 2024 12:17
@tyxla
Copy link
Member

tyxla commented Sep 12, 2024

This will address part of #37011

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall 👍 Thanks @zaguiini!

I've left a couple of minor suggestions.

Also the PR could use a CHANGELOG entry.

@zaguiini
Copy link
Member Author

Thanks for the help @tyxla @mirka this is ready for another review!

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🚀

@zaguiini zaguiini enabled auto-merge (squash) September 13, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants