Global Styles: refactor site background controls and move site global styles into Background group #65304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Sep 13, 2024
|
Size Change: +229 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
This works great:
Two small things if you can fix them easily, otherwise we can follow up.
Can you move the background item below color? So it's not at the top.
There's a typographic widow here:
We can fix that typographic widow in a few ways, but the best way to do it is to replace the description with a Text component. If you do that, it's automatically handled across localizations too.
An alternate fix is to rephrase it, perhaps like so:
|
Thanks for the quick feedback! I'll make those changes early next week. 🙇🏻 |
ramonjd
force-pushed
the
update/refactor-background-panel-into-sub-controls
branch
from
1e2b21c
to
e541285
Compare
…component. Moving styles. This is in preparation for adding colors and other background controls later.
Updating props
…color. Shorten copy and wrap in Text to avoid widows.
ramonjd
force-pushed
the
update/refactor-background-panel-into-sub-controls
branch
from
e541285
to
9996094
Compare
ramonjd
deleted the
update/refactor-background-panel-into-sub-controls
branch
This was referenced Sep 26, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? How?
Builds upon #63216 Props goes to @amitraj2203
The PR:
The follow up to this PR is to carry on with the objective of #63216, which is to combine background colors into the background panel.
Note
This PR builds on the ideas in #63216. Any props here should include those from that PR.
Why?
As mentioned in #63216 (comment), the original PR needed a little refactoring before adding background color to the mix.
The main reason was to be able to better manage individual controls within a style group.
Testing Instructions
The only difference should be that top-level background image controls are now available under a "Background" item in the Site Editor's style navigation.
There should otherwise be no regressions in the way the background image UI works for blocks or block global styles.
Kapture.2024-09-13.at.14.00.07.mp4