-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove editorMode from blockProps #65326
Conversation
Size Change: -19 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
75e7489
to
1463954
Compare
1463954
to
2904872
Compare
This reverts commit f53ac60.
I think this needs to be backported to 6.7 as #65963 depends on it. c.c. @andrewserong and @getdave if I'm misunderstanding something. 🙇 |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
What?
Seeing if there's a performance improvement by removing editorMode from the blockProps that was added in #64573
Why?
Potential performance improvement/code quality.
How?
Remove from block props, add a check within event listener.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast