Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: run the tests against PHP 8.3 #65357

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 15, 2024

What?

GH Actions: run the tests against PHP 8.3

PHP 8.3 was released nearly a year ago. It is unclear to me why the PHP tests are not being run against PHP 8.3, so let's fix this.

GH Actions/test-php: remove redundant step

This should have been removed when support for PHP < 7.2 was dropped.

PHP 8.3 was released nearly a year ago. It is unclear to me why the PHP tests are not being run against PHP 8.3, so let's fix this.
This should have been removed when support for PHP < 7.2 was dropped.
@jrfnl jrfnl requested a review from desrosj as a code owner September 15, 2024 16:45
Copy link

github-actions bot commented Sep 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jrfnl <jrf@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jrfnl jrfnl added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Sep 15, 2024
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrfnl! This makes sense and looks good.

@desrosj desrosj enabled auto-merge (squash) September 26, 2024 16:43
@desrosj desrosj enabled auto-merge (squash) September 26, 2024 16:44
@desrosj desrosj merged commit cb90a76 into trunk Sep 26, 2024
68 of 69 checks passed
@desrosj desrosj deleted the fix/ghactions-phpunit-tests branch September 26, 2024 16:44
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 26, 2024
@desrosj
Copy link
Contributor

desrosj commented Sep 26, 2024

I've gone and updated the branch protection rule for trunk to require the updated job name "PHP 8.3 (WP previous major version) on ubuntu-latest" to pass instead of the old, PHP 8.2 one. This should be all set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants