-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove additional Typeset screen and surface typesets in the typography panel #65579
Conversation
Size Change: -226 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
71b42d3
to
6d9a472
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works as advertised.
As a side note, I think this UI might be lacking some contextual information about where—as in, to which elements—the Font Families within a Typeset are being applied. cc. @richtabor |
6d9a472
to
cc9970f
Compare
cc9970f
to
b1eaa4f
Compare
Flaky tests detected in b1eaa4f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11075476932
|
Noting that the test failure is related to a flaky test case reported here: #63665. |
…hy panel (#65579) * Remove additional Typeset screen and surface typesets in the typography panel. * Merge custom and theme font families in getFontFamilyFromSetting.
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: d26e784 |
…hy panel (WordPress#65579) * Remove additional Typeset screen and surface typesets in the typography panel. * Merge custom and theme font families in getFontFamilyFromSetting.
…typography panel (WordPress#65579)" This reverts commit 831b8da.
What?
This PR surfaces the typography variations ("typesets") directly in the Typography panel, removing the need for a separate Typeset screen right now.
Why?
See #65575
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast