-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DropZone class names on drop #65798
Conversation
Size Change: -9 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
fe65807
to
f05e4bf
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in my testing and makes sense to be rid of an extra classname, especially when we have so many others in place 👍
Thanks @ajlende!
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk.
|
Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Manual cherry-pick opened in #65924 |
Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
What?
Removes the
is-dragging-over-element
classname on drop.Why?
Fixes #65788.
How?
Removes the
is-dragging-over-element
on thedragend
event asdragleave
isn't called on drop.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
fixed-drop-flow.mp4