Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery width to match with other elements width #6580

Merged
merged 1 commit into from
May 14, 2018

Conversation

jorgefilipecosta
Copy link
Member

Gallery width should match the width of other elements in the editor and in the frontend. We had a rule in the backend for that but not on the frontend. This rule was added to the frontend.
Fixes: #4548

screen shot 2018-05-04 at 08 40 55

screen shot 2018-05-04 at 08 33 10

How has this been tested?

Verify the gallery block width matches exactly the width of other blocks in frontend and backend as shown in the screenshots.

@jorgefilipecosta jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label May 4, 2018
@jorgefilipecosta jorgefilipecosta self-assigned this May 4, 2018
@jorgefilipecosta jorgefilipecosta force-pushed the fix/gallery-width-frontend branch from e2866a3 to 180efd8 Compare May 4, 2018 07:45
@jorgefilipecosta jorgefilipecosta added the [Status] In Progress Tracking issues with work in progress label May 4, 2018
@jorgefilipecosta jorgefilipecosta force-pushed the fix/gallery-width-frontend branch 2 times, most recently from c7cd8cd to 32be135 Compare May 9, 2018 14:16
@jorgefilipecosta jorgefilipecosta removed the [Status] In Progress Tracking issues with work in progress label May 9, 2018
@jorgefilipecosta jorgefilipecosta requested a review from jasmussen May 9, 2018 14:17
@jasmussen
Copy link
Contributor

Very cool, thanks for doing this! Needs a rebase I think, but seems to work fine in my theme. 👍 👍

Gallery width should match the width of other elements in both the editor and in the frontend. We had a rule in the backend for that but not on the frontend. This rule was migrated to the frontend.
@jorgefilipecosta jorgefilipecosta force-pushed the fix/gallery-width-frontend branch from 32be135 to dfdbaa0 Compare May 14, 2018 13:11
@jorgefilipecosta jorgefilipecosta merged commit 307e357 into master May 14, 2018
@jorgefilipecosta jorgefilipecosta deleted the fix/gallery-width-frontend branch May 14, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants