Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block: set LTR direction for RTL languages #65891

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

sabernhardt
Copy link
Contributor

Fixes #65890

Testing Instructions

  1. Set your site language to a right-to-left language (and set your profile language to match the site).
  2. Go to the post editor.
  3. Add a Code block and insert some code.
  4. Save changes.
  5. View the direction and alignment both in the editor and on the front.

Copy link

github-actions bot commented Oct 5, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Oct 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sabernhardt
Copy link
Contributor Author

In addition to the ltr direction, the block seems to need left text alignment. WordPress admin CSS adds unicode-bidi: embed without the text alignment, but I did not notice a need for that property with the one code example.

Note that if your active theme is a classic theme, the admin CSS could affect code display within the post editor.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Similar styles exist for the HTML block too, and I think this PR makes sense.

Comment on lines +3 to +6
/*!rtl:begin:ignore*/
direction: ltr;
text-align: left;
/*!rtl:end:ignore*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since style-rtl.css is also enqueued on the editor side, I don't think this style is necessary.

image

@@ -9,5 +9,9 @@
font-family: inherit;
overflow-wrap: break-word;
white-space: pre-wrap;
/*!rtl:begin:ignore*/
direction: ltr;
text-align: left;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think text-align:left is necessary, but what do you think?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the default behavior for direction: ltr is to align text to the left, setting text-align: left is not strictly required in most cases, it is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code block: fix direction for RTL languages
3 participants