Media Library: Expose filters dropdown for individual images, such as with the Image block #65965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @cagivacode, @tiagogon, @kylemcph, @Wadowad, @RoqueCampos, @venture89, @spncr, @simonPaulBergzeit, @Ezokia, @fylgjur, @sbathompson-he, @dnnsjsk. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +97 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Oct 31, 2024
|
Thanks for the review, @draganescu! I'll merge this in now. I've opened a separate issue over in #66663 for the follow-up task of looking into ensuring that images added to posts or pages get attached to that post or page in Gutenberg. Or, at the very least, that issue is a good place for us to continue the discussion 🙂 |
andrewserong
deleted the
fix/expose-media-library-filters-for-image-block
branch
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
… with the Image block (WordPress#65965) * Media Library: Expose filters dropdown for individual images, such as with the Image block * Rename to be a little more generic Unlinked contributors: cagivacode, tiagogon, kylemcph, Wadowad, yoanmarchal, RoqueCampos, venture89, spncr, simonPaulBergzeit, Ezokia, fylgjur, sbathompson-he, dnnsjsk. Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: finalwebsites <finalwebsites@git.wordpress.org> Co-authored-by: Drivingralle <drivingralle@git.wordpress.org> Co-authored-by: johnbillion <johnbillion@git.wordpress.org> Co-authored-by: torounit <toro_unit@git.wordpress.org> Co-authored-by: paaljoachim <paaljoachim@git.wordpress.org> Co-authored-by: Soean <soean@git.wordpress.org> Co-authored-by: jamesmrobinson <imaginarymedia@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #12753
Expose the Filters dropdown within the media library modal that's used by the Image block (the default state for the
MediaUploadcomponent).Why?
As reported in #12753, it's useful for folks to be able to filter by unattached images, etc, as folks can currently do via the modal for the Gallery block. This PR essentially gets parity between the Image and Gallery blocks when it comes to the filters available from the media library.
Note as reported in #12753, there is likely still some behaviour here that could be buggy. For example, this needs to be investigated:
This still occurs with this PR:
However if I upload an image directly to a post within Gutenberg, it is attached correctly:
So, while reviewing this PR, keep that in mind when looking at the filters. If that issue feels like a blocker, we can pause this PR for now while investigating the above issue. It might need a little further investigation so that attaching images to a post only happens when we believe it's likely what the user intended 🤔
How?
Update the
MediaUploadcomponent so that when selecting single image media, the Select media frame is configured to use thefilterableoption of'uploaded'. To achieve this, the proposal here is to extendwp.media.view.MediaFrame.Select, in a similar way to how the featured image frame currently works. We then overridecreateStates, using the same code as in core, only withfilterableadded in to switch on the filters.Testing Instructions
Screenshots or screencast
2024-10-09.16.56.13.mp4