Use consistent canvas frame spacing on device preview and zoom out #66018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -18 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 10, 2024
Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: b352fc5 |
|
Zoom out’s vertical toolbar wants |
|
The most important seems to be a consistent top / bottom padding |
Yes. We can tweak the horizontal padding. But bigger question is if the caveats and complexity of the vertical toolbar is worth it. What's your opinion? |
|
Technically speaking, It does add duplication and complexity and the behavior is not consistent (full width blocks). I would love to understand more if it adds a big value, either in terms of design or UX as otherwise, I'd be in favor of removing it. |
ciampo
pushed a commit
that referenced
this pull request
Oct 14, 2024
Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…#66018) Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The zoom out frame spacing was set to
48px, while the preview frame for responsive views is set to36pxand64pxbased on viewport. Instead let's just keep it the same value (40px) so that there is less variance when switching between each of these.Testing Instructions
Screenshots or screencast
CleanShot.2024-10-10.at.14.07.40.mp4