Update site icon and title position #66171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
reviewed
Oct 16, 2024
| @@ -68,7 +68,7 @@ const SiteHub = memo( | |||
| label={ __( 'Go to the Dashboard' ) } | |||
| className="edit-site-layout__view-mode-toggle" | |||
| style={ { | |||
| transform: 'scale(0.5)', | |||
| transform: 'scale(0.5333) translateX(-4px)', // Offset to position the icon 12px from viewport edge | |||
There was a problem hiding this comment.
I guess this is the trouble you're referring to. It's a curious number. How does the math work out?
There was a problem hiding this comment.
Yes. The icon/button is 60x60 in the editor and gets scaled down when you exit the editor. The 0.5 scale transform results in a 30x30 icon, which doesn't align with standard button sizes and creates awkward alignments. Transforming by 0.5333 creates a 32px icon which is easier to align with other elements.
There was a problem hiding this comment.
Makes sense. I wonder if this needs to be in a comment?
|
Size Change: +59 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Oct 17, 2024
jameskoster
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 17, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 3457f6b |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #66166 (comment).
Gosh, this turned out to be more trouble than I expected. Curious if y'all think it's worth it.
What?
Why?
Coherence.
How?
In the image below the top screenshot is trunk, the bottom is this PR. The guidelines demonstrate the alignment.