Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $font-line-height-x-large error #66184

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Oct 16, 2024

What?

Hardcode $font-line-height-x-large from #65418 which didn't get backported.

Why?

Wasn't sure if we wanted all the new variables in wp/6.7, so this is a fix without including all of them.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ajlende ajlende added the [Type] Bug An existing feature does not function as intended label Oct 16, 2024
@ajlende ajlende requested a review from jameskoster October 16, 2024 19:37
@ajlende ajlende self-assigned this Oct 16, 2024
Copy link
Contributor

@jeryj jeryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My CSS builds now 👍🏻

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ajlende <ajlende@git.wordpress.org>
Co-authored-by: jeryj <jeryj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jeryj jeryj added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Oct 16, 2024
@jeryj jeryj force-pushed the wp67/fix/font-line-height-x-large branch from 83c2252 to 150aed1 Compare October 16, 2024 19:54
@ajlende
Copy link
Contributor Author

ajlende commented Oct 16, 2024

The Compressed Size / Check (pull_request) check will continue to fail because it's trying to build the previous commit which is broken, so we need someone with commit access to merge this one.

@ciampo ciampo merged commit 97dde20 into wp/6.7 Oct 16, 2024
42 of 61 checks passed
@ciampo ciampo deleted the wp67/fix/font-line-height-x-large branch October 16, 2024 22:09
@ciampo
Copy link
Contributor

ciampo commented Oct 16, 2024

we need someone with commit access to merge this one.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants