-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add radius foundation and tokens to storybook #66219
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I think there's a question about the visual style we want to apply across these docs, it may be good to decide on a specific illustration style (which could be what you suggested, but it could also be this), and then roll it out consistently. I think as a first draft this is fine. What do you think? Nice work. |
ed7baa6
to
71f6f28
Compare
Rebased on top of latest changes, and pushed a couple of improvements / fixes. In particular, I refactored the table so that it can be a more generic and work for both radius and elevation tokens. It's still a bit hacky, and we will definitely want to refine it (alongside other docs componentry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work @jameskoster! 🚀
Left a few suggestions, but this is good to go anyway!
71f6f28
to
d708d90
Compare
@tyxla Since I was the last one to work on this PR (and I'm not sure about Jay's availability this week), I've addressed the remaining feedback. Will merge as soon as CI checks pass ✅ |
Thanks @ciampo and @jameskoster 🙌 |
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
What?
Adds radius foundations and tokens to storybook.
Why?
Testing Instructions
npm run storybook