Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radius foundation and tokens to storybook #66219

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Conversation

jameskoster
Copy link
Contributor

What?

Adds radius foundations and tokens to storybook.

Why?

  • Documenting the foundations creates an important point of reference for updating (or creating new) components and UIs.
  • Documenting the tokens makes them more discoverable.

Testing Instructions

  1. npm run storybook
  2. Check out the new pages; 'Foundations / Design Language / Radius' and 'Tokens / Radius'
Foundations page Tokens page
Screenshot 2024-10-17 at 18 30 56 Screenshot 2024-10-17 at 18 31 05

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Storybook Storybook and its stories for components Design System Issues related to the system of combining components according to best practices. labels Oct 17, 2024
@jameskoster jameskoster requested review from a team October 17, 2024 17:32
Copy link

github-actions bot commented Oct 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jameskoster jameskoster mentioned this pull request Oct 10, 2024
5 tasks
@jasmussen
Copy link
Contributor

I think there's a question about the visual style we want to apply across these docs, it may be good to decide on a specific illustration style (which could be what you suggested, but it could also be this), and then roll it out consistently.

I think as a first draft this is fine. What do you think? Nice work.

@ciampo ciampo force-pushed the add/storybook-radius branch from ed7baa6 to 71f6f28 Compare October 18, 2024 12:57
@ciampo
Copy link
Contributor

ciampo commented Oct 18, 2024

Rebased on top of latest changes, and pushed a couple of improvements / fixes.

In particular, I refactored the table so that it can be a more generic and work for both radius and elevation tokens. It's still a bit hacky, and we will definitely want to refine it (alongside other docs componentry)

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @jameskoster! 🚀

Left a few suggestions, but this is good to go anyway!

storybook/stories/foundations/design-language/radius.mdx Outdated Show resolved Hide resolved
storybook/stories/tokens/components.tsx Outdated Show resolved Hide resolved
@ciampo ciampo force-pushed the add/storybook-radius branch from 71f6f28 to d708d90 Compare October 24, 2024 09:03
@ciampo
Copy link
Contributor

ciampo commented Oct 24, 2024

@tyxla Since I was the last one to work on this PR (and I'm not sure about Jay's availability this week), I've addressed the remaining feedback.

Will merge as soon as CI checks pass ✅

@ciampo ciampo enabled auto-merge (squash) October 24, 2024 09:05
@ciampo ciampo merged commit 0d91946 into trunk Oct 24, 2024
64 of 65 checks passed
@ciampo ciampo deleted the add/storybook-radius branch October 24, 2024 09:37
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 24, 2024
@tyxla
Copy link
Member

tyxla commented Oct 24, 2024

Thanks @ciampo and @jameskoster 🙌

karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System Issues related to the system of combining components according to best practices. Storybook Storybook and its stories for components [Type] Enhancement A suggestion for improvement.
Projects
Status: 💫 Done
Development

Successfully merging this pull request may close these issues.

4 participants